Skip to content

@W-18818802 add billing phone number to customer on registration#2653

Merged
syadupathi-sf merged 10 commits intodevelopfrom
syadupathi.W-18818802.custPhNum
Jul 3, 2025
Merged

@W-18818802 add billing phone number to customer on registration#2653
syadupathi-sf merged 10 commits intodevelopfrom
syadupathi.W-18818802.custPhNum

Conversation

@syadupathi-sf
Copy link
Collaborator

@syadupathi-sf syadupathi-sf commented Jun 25, 2025 •
edited
Loading

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • When a guest user places an order and then creates a user account, the changes in this PR ensures that the billing phone number is saved as the account phone number.

Screenshot 2025-07-02 at 5 03 39 PM

How to Test-Drive This PR

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@syadupathi-sf syadupathi-sf requested a review from a team as a code owner June 25, 2025 22:02
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 25, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@syadupathi-sf syadupathi-sf added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jun 26, 2025
dannyphan2000
dannyphan2000 previously approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@dannyphan2000 dannyphan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-07-02 at 3 20 06 PM

QA is done via https://sushma-1cc-production.mobify-storefront.com/
Verified that it works!

bendvc
bendvc previously requested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@bendvc bendvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description. This gos along way to help onboard reviewers on to what this ticket is about, we can't rely solely on gus tickets as this is a open source repo and the developers most likely won't have access to see what they are about.

@bendvc
Copy link
Contributor

bendvc commented Jul 2, 2025

Please update the PR description. This gos along way to help onboard reviewers on to what this ticket is about, we can't rely solely on gus tickets as this is a open source repo and the developers most likely won't have access to see what they are about.

Otherwise the change looks good.

@bendvc
Copy link
Contributor

bendvc commented Jul 2, 2025

Please update the CHANGELOG.md file to include your PR and a short description of what your change does.

alexvuong
alexvuong reviewed Jul 2, 2025
View reviewed changes
packages/template-retail-react-app/app/pages/checkout/confirmation.test.js Outdated
// Verify other expected customer data (firstName/lastName come from order's billingAddress)
expect(registrationRequestBody.customer.firstName).toBe(mockOrder.billingAddress.firstName)
expect(registrationRequestBody.customer.lastName).toBe(mockOrder.billingAddress.lastName)
expect(registrationRequestBody.customer.email).toBe(mockOrder.customerInfo.email)
Copy link
Contributor

@alexvuong alexvuong Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint?

Copy link
Collaborator Author

@syadupathi-sf syadupathi-sf Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls elaborate? npm run lint doesn't have any errors

alexvuong
alexvuong previously approved these changes Jul 2, 2025
View reviewed changes
@syadupathi-sf syadupathi-sf requested a review from alexvuong July 2, 2025 23:54
@syadupathi-sf
Merge branch 'develop' into syadupathi.W-18818802.custPhNum
b87dd42 
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
@syadupathi-sf syadupathi-sf enabled auto-merge (squash) July 3, 2025 16:23
@syadupathi-sf syadupathi-sf changed the title @W-18818802 add shipment phone number to customer on registration @W-18818802 add billing phone number to customer on registration Jul 3, 2025
@syadupathi-sf syadupathi-sf dismissed bendvc’s stale review July 3, 2025 18:16

The changes requested were ade

dannyphan2000
dannyphan2000 approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@dannyphan2000 dannyphan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified that this code is working successfully in MRT.

@syadupathi-sf syadupathi-sf merged commit c68cd22 into develop Jul 3, 2025
35 checks passed
kumaravinashcommercecloud pushed a commit that referenced this pull request Aug 12, 2025
@syadupathi-sf @kumaravinashcommercecloud
@W-18818802 add billing phone number to customer on registration (#2653)
f1e6265 
* W-18818802 add shipment phone number to customer on registration

* W-18818802 address code review comments

* fix lint errors

* updated change log

* address code review comment

* fix lint errors afrer conflict merge

* minor change to test comment

---------

Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexvuong alexvuong alexvuong approved these changes

@dannyphan2000 dannyphan2000 dannyphan2000 approved these changes

@patricksullivansf patricksullivansf patricksullivansf left review comments

@kumaravinashcommercecloud kumaravinashcommercecloud Awaiting requested review from kumaravinashcommercecloud

@bendvc bendvc Awaiting requested review from bendvc

Assignees

No one assigned

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@syadupathi-sf @cc-prodsec @bendvc @alexvuong @patricksullivansf @dannyphan2000 @kumaravinashcommercecloud